Simplified Test and Fixed Bug at the Same Time
One of my co-workers brought up a bug that I hadn't noticed up to now - one of the test methods - that is, a method that returns a boolean about the Merchant argument, was not working, and there was a far simpler way to implement it. Basically, when we were dealing with Hashes in the data structures, it was as efficient a way to handle the problem - modulo the bug, as we could have. But now that we have the Merchant and within it, the Opportunity objects, with their own boolean methods, this implementation really became - ask the Merchant to ask it's Opportunity if it's a live deal.
Far simpler in the code.
Plus, at the same time, we're doing the right test because when I coded that one up, I did it right. Go figure.
In any case, a simple fix, and we reduced the lines of code. Not bad.